Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versions OAuth #42

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Versions OAuth #42

merged 3 commits into from
Jan 10, 2025

Conversation

louispt1
Copy link
Collaborator

This PR:

  • Adjusts the engine and model clients to use the version tags to decide which engine/model to communicate with
  • Includes a 'current_version' method in the base controller which grabs the version out of the params (if possible) so it is accessible to other controllers.
  • Removes the trailing slash on the idp url in the local application config.
  • Refactors the version url generation slightly

@louispt1 louispt1 requested a review from noracato December 20, 2024 08:27
noracato
noracato reviewed Jan 10, 2025
View reviewed changes
app/controllers/users/registrations_controller.rb
@@ -71,7 +70,7 @@ def stats_for_destroy
personal_access_tokens: current_user.personal_access_tokens.not_expired.count,
oauth_applications: current_user.oauth_applications.count,
collections: 0
# collections: current_user.collections.count
# collections: current_user.collections.count # TODO: Re-Implement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!

app/controllers/api/v1/saved_scenarios_controller.rb Outdated
@@ -68,7 +68,15 @@ def saved_scenario_params
end

def engine_client
MyEtm::Auth.engine_client(current_user)#, scopes: doorkeeper_token.scopes)
MyEtm::Auth.engine_client(current_user, active_version_tag)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bring back scopes for access tokens!!

@noracato noracato merged commit 9f91eff into master Jan 10, 2025
2 of 4 checks passed
@noracato noracato deleted the version-logic branch January 10, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noracato noracato noracato left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louispt1 @noracato